<html>
<head><meta charset="utf-8"><title>Proposal to merge: rust-lang/wg-async-foundations#68 · wg-async-foundations · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/index.html">wg-async-foundations</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html">Proposal to merge: rust-lang/wg-async-foundations#68</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="231318044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231318044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231318044">(Mar 22 2021 at 14:24)</a>:</h4>
<p>I'd like to merge rust-lang/wg-async-foundations <a href="https://github.com/rust-lang/rust/issues/68">#68</a> -- any seconds? :)</p>



<a name="231330475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231330475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231330475">(Mar 22 2021 at 15:32)</a>:</h4>
<p>I like the proposal in general, but as I noted in the PR, I think it would be good to try to abstract a tiny bit more and mention <code>block_on</code> as an example instead of implying that fixing that fixes all of their issues.</p>



<a name="231348053"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231348053" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231348053">(Mar 22 2021 at 17:07)</a>:</h4>
<p>second, we can address the specificity question during collation</p>



<a name="231371477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231371477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231371477">(Mar 22 2021 at 19:33)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> oh, I missed your comments. I do think the <code>block_on</code> could be improved a bit as well, though I'm not inclined to block.</p>



<a name="231441713"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231441713" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231441713">(Mar 23 2021 at 09:25)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> you around?</p>



<a name="231441744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231441744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231441744">(Mar 23 2021 at 09:25)</a>:</h4>
<p>I was curious how you felt about <a href="https://github.com/rust-lang/wg-async-foundations/pull/68#discussion_r599020094">this edit</a></p>



<a name="231444881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231444881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231444881">(Mar 23 2021 at 09:56)</a>:</h4>
<p>Looks good. I might eventually take a stab at editing the morals section to ensure the story is well understood as being generally applicable</p>



<a name="231532801"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187312-wg-async-foundations/topic/Proposal%20to%20merge%3A%20rust-lang/wg-async-foundations%2368/near/231532801" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187312-wg-async-foundations/topic/Proposal.20to.20merge.3A.20rust-lang.2Fwg-async-foundations.2368.html#231532801">(Mar 23 2021 at 19:50)</a>:</h4>
<p>merged</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>